Feature/osis 74 delete credential

[XinLi0207]

following VMware API documentation https://developer.vmware.com/apis/1034#/s3credential/deleteCredential

[codecov]

Codecov Report

Merging #98 (d269819) into development/1.1 (f10a754) will increase coverage by 0.17%.
The diff coverage is 83.58%.

❗ Current head d269819 differs from pull request most recent head dcf4ef1. Consider uploading reports for the commit dcf4ef1 to get more accurate results

@@                  Coverage Diff                  @@
##             development/1.1      #98      +/-   ##
=====================================================
+ Coverage              63.23%   63.40%   +0.17%     
- Complexity               398      399       +1     
=====================================================
  Files                     70       70              
  Lines                   2266     2282      +16     
  Branches                 156      157       +1     
=====================================================
+ Hits                    1433     1447      +14     
  Misses                   766      766              
- Partials                  67       69       +2     

Impacted Files	Coverage Δ
...m/scality/osis/vaultadmin/impl/VaultAdminImpl.java	78.50% <0.00%> (ø)
...lity/osis/service/impl/ScalityOsisServiceImpl.java	88.15% <84.12%> (-0.02%)	⬇️
.../com/scality/osis/utils/ScalityModelConverter.java	96.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[williamlardier]

LGTM

[williamlardier]

Nit: the nested try/catch in the PRs could be avoided to simplify the code (but I agree, this is not the highest priority today 😄 ).

[bert-e]

Hello xinliscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Conflict

There is a conflict between your branch feature/OSIS-74-delete-credential and the
destination branch development/1.1.

Please resolve the conflict on the feature branch (feature/OSIS-74-delete-credential).

git fetch && \
git checkout origin/feature/OSIS-74-delete-credential && \
git merge origin/development/1.1

Resolve merge conflicts and commit

git push origin HEAD:feature/OSIS-74-delete-credential

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[XinLi0207]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/1.1

The following branches will NOT be impacted:

• development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/1.1

The following branches have NOT changed:

• development/1.0

Please check the status of the associated issue OSIS-74.

Goodbye xinliscality.