Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: OSIS-88 getAnonymousUser #105

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

XinLi0207
Copy link
Contributor

@XinLi0207 XinLi0207 commented Aug 24, 2022

this API is needed for OSE healthcheck route /api/v1/core
after implementing this API, now the response of https://192.168.198.12/api/v1/core is like:

{
    "name": "Cloud Director Object Storage Extension",
    "description": "Object Storage Extension for VMware Cloud Director",
    "version": "2.1.1-19362139",
    "buildDate": "2022-02-15T10:24:38.725+00:00"
}

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #105 (0cb264f) into main (21632c1) will increase coverage by 0.09%.
The diff coverage is 76.47%.

@@             Coverage Diff              @@
##               main     #105      +/-   ##
============================================
+ Coverage     63.57%   63.66%   +0.09%     
- Complexity      398      404       +6     
============================================
  Files            70       71       +1     
  Lines          2306     2323      +17     
  Branches        160      160              
============================================
+ Hits           1466     1479      +13     
- Misses          768      772       +4     
  Partials         72       72              
Impacted Files Coverage Δ
...ain/java/com/scality/osis/model/AnonymousUser.java 63.63% <63.63%> (ø)
...lity/osis/service/impl/ScalityOsisServiceImpl.java 87.92% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@XinLi0207 XinLi0207 force-pushed the feature/OSIS-88-getAnonymousUser branch from 8cc9eff to a2f6b1f Compare August 25, 2022 10:15
@XinLi0207 XinLi0207 marked this pull request as ready for review August 25, 2022 10:15
@XinLi0207 XinLi0207 requested a review from a team as a code owner August 25, 2022 10:15
Copy link

@williamlardier williamlardier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as my comment is not a mandatory change, but reducing the load of logs in our projects is also important 😄

@XinLi0207 XinLi0207 force-pushed the feature/OSIS-88-getAnonymousUser branch from d84b2a4 to 0cb264f Compare August 26, 2022 07:52
@XinLi0207 XinLi0207 merged commit 2b7cffa into main Aug 26, 2022
@XinLi0207 XinLi0207 deleted the feature/OSIS-88-getAnonymousUser branch August 26, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants