improvement: OSIS-76-make-s3-capabilities-file-path-configurable #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello anurag4dsb,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
anurag4DSB
force-pushed
the
improvement/OSIS-76-standerdize-and-update-s3capabilities
branch
from
1878f20
to
a77a563
Compare
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
============================================
+ Coverage 63.66% 63.68% +0.01%
Complexity 404 404
============================================
Files 71 71
Lines 2323 2324 +1
Branches 160 160
============================================
+ Hits 1479 1480 +1
Misses 772 772
Partials 72 72
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
anurag4DSB
force-pushed
the
improvement/OSIS-76-standerdize-and-update-s3capabilities
branch
from
183d8ca
to
d70df80
Compare
XinLi0207
approved these changes
Aug 24, 2022
anurag4DSB
force-pushed
the
improvement/OSIS-76-standerdize-and-update-s3capabilities
branch
2 times, most recently
from
18b2e33
to
0b52a5c
Compare
- not having any exlusions will give us a heads up about upcoming issues
- actual version specific s3capabilities will be moved to federation
Current set of capabilities in S3C v9.1:
```json
{
"s3_DeleteBucketAnalyticsConfiguration": {},
"s3_DeleteBucketIntelligentTieringConfiguration": {},
"s3_DeleteBucketInventoryConfiguration": {},
"s3_DeleteBucketMetricsConfiguration": {},
"s3_DeleteBucketOwnershipControls": {},
"s3_DeletePublicAccessBlock": {},
"s3_delete_bucket_lifecycle": {},
"s3_GetBucketAccelerateConfiguration": {},
"s3_GetBucketAnalyticsConfiguration": {},
"s3_GetBucketIntelligentTieringConfiguration": {},
"s3_GetBucketInventoryConfiguration": {},
"s3_GetBucketLifecycle": {},
"s3_GetBucketLogging": {},
"s3_GetBucketMetricsConfiguration": {},
"s3_GetBucketPolicyStatus": {},
"s3_GetBucketRequestPayment": {},
"s3_GetObjectAttributes": {},
"s3_GetObjectTorrent": {},
"s3_GetPublicAccessBlock": {},
"s3_ListBucketAnalyticsConfigurations": {},
"s3_ListBucketIntelligentTieringConfigurations": {},
"s3_ListBucketInventoryConfigurations": {},
"s3_ListBucketMetricsConfigurations": {},
"s3_PutBucketAccelerateConfiguration": {},
"s3_PutBucketAnalyticsConfiguration": {},
"s3_PutBucketIntelligentTieringConfiguration": {},
"s3_PutBucketInventoryConfiguration": {},
"s3_PutBucketLifecycle": {},
"s3_PutBucketLogging": {},
"s3_PutBucketMetricsConfiguration": {},
"s3_PutBucketRequestPayment": {},
"s3_PutPublicAccessBlock": {},
"s3_RestoreObject": {},
"s3_SelectObjectContent": {},
"s3_WriteGetObjectResponse": {}
}
```
anurag4DSB
force-pushed
the
improvement/OSIS-76-standerdize-and-update-s3capabilities
branch
from
0b52a5c
to
cbefecc
Compare
KillianG
approved these changes
Aug 26, 2022
anurag4DSB
deleted the
improvement/OSIS-76-standerdize-and-update-s3capabilities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standardizes s3 capabilities with minimal changes. We need to refactor the whole code base and the format of the files will change to JSON/YAML for all resources. Hence this is the most minimal change with code we are going to refactor.