-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-create waterfall branches in bump version action #113
pre-create waterfall branches in bump version action #113
Conversation
By creating the waterfall branches in bump version we ensure when opening the PR that bert-e is already happy and we don't need to solve conflict ourselves knowing that we don't want to keep the upade as the update only contains the version bump for version x.y and we try to merge in upper version branches wo th version is already x+1.y+1 and we don't want to forward-port this change.
BTW: this action is only used by xcore projects for now. |
@lavigne958 interesting; I understand your PR as:
If yes, I'm OK with you moving forward with this approach as it helps you in the short term, but we could do better for the greater good: we could add an option to bert-e to solve conflicts with a specific strategy, as you did; would look like a command |
Hi yes this is exactly what it is 🤩 hoooo my god this is so cool ! that would help us so much on each artesca release you have no idea. So far as I said this is only used in xcore internal repo so that's safe to use I think. but yes the bert-e approach would be awesome ! on behalf of all personal workinf on artesca CI: thank you so much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a comment that is optional to address, therefore approving.
In case of left over from previous failed run, cleanup any branches that could prevent the workflow from running
By creating the waterfall branches in bump version we ensure when opening the PR that bert-e is already happy and we don't need to solve conflict ourselves knowing that we don't want to keep the upade as the update only contains the version bump for version x.y and we try to merge in upper version branches wo th version is already x+1.y+1 and we don't want to forward-port this change.