Improve ovh vm cleanup #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nootal
requested changes
Sep 8, 2023
There was a problem hiding this comment.
@lavigne958 please add at least a message in the commit explaining why this change is better than the situation before ;)
By defautl any bash command runs with `set -e` which enables: exit on error Running the `openstack server delete` command may exit with an error but we don't want to stop there. Around that specific part of the action do not exit on error.
lavigne958
force-pushed
the
feature/improve_ovh_cleanup
branch
from
85a9d2d
to
cf42a0a
Compare
|
done @nootal 😉 |
nootal
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.