feat: request cancellation

[DorianMaliszewski]

Possibility to cancel a Promise with an enhanced promise type

[codecov]

Codecov Report

Merging #369 (b597284) into master (08581aa) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #369   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          346       360   +14     
  Branches        56        60    +4     
=========================================
+ Hits           346       360   +14     

Impacted Files	Coverage Δ
packages/use-dataloader/src/useDataLoader.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08581aa...b597284. Read the comment docs.

[vincentaudebert]

I get this

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
          at TestComponent (/Volumes/Projets/scaleway-lib/node_modules/@testing-library/react-hooks/lib/helpers/createTestHarness.js:22:5)
          at DataLoaderProvider (/Volumes/Projets/scaleway-lib/packages/use-dataloader/src/DataLoaderProvider.tsx:33:31)
          at wrapper (/Volumes/Projets/scaleway-lib/packages/use-dataloader/src/__tests__/useDataLoader.tsx:28:20)
          at Suspense
          at ErrorBoundary (/Volumes/Projets/scaleway-lib/node_modules/react-error-boundary/dist/react-error-boundary.cjs.js:40:35)

      123 |     async cacheKey => {
      124 |       try {
    > 125 |         dispatch(Actions.createOnLoading())
          |         ^
      126 |         const promise = method()
      127 |         cancelMethodRef.current = promise.cancel
      128 |         const result = await promise.then(res => res)

in the tests. Is there no way to avoid this?

(Tests are fairly long)

[adriengibrat]

I'm not fan of enhanced promise type :

Why not using the native fetch abort mechanism?

the fetch() promise rejects with an "AbortError" DOMException.

https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal

using standards may be a better way than enhanced promise type

[DorianMaliszewski]

I'm not fan of enhanced promise type :

Why not using the native fetch abort mechanism?

the fetch() promise rejects with an "AbortError" DOMException.

https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal

@adriengibrat We should handle both Axios and Fetch behaviour so we need to keep something flexible to ensure a compatibility between both. May in the fututre we will directly integrate a custom hook for each ones.

[vincentaudebert]

💯