fix(use-dataloader): avoid exception when options are not defined (#148)

* fix(use-dataloader): avoid exception when options are not defined * test: add bug reproduction
scaleway · May 3, 2021 · 347e539 · 347e539
1 parent b84d555
commit 347e539
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/use-dataloader/src/__tests__/useDataLoader.test.js b/packages/use-dataloader/src/__tests__/useDataLoader.test.js
@@ -20,6 +20,23 @@ const wrapper = ({ children }) => (
 )
 
 describe('useDataLoader', () => {
+  test('should render correctly without options', async () => {
+    const { result, waitForNextUpdate, rerender } = renderHook(
+      props => useDataLoader(props.key, props.method),
+      {
+        wrapper,
+        initialProps,
+      },
+    )
+    expect(result.current.data).toBe(undefined)
+    expect(result.current.isLoading).toBe(true)
+    rerender()
+    await waitForNextUpdate()
+    expect(result.current.data).toBe(true)
+    expect(result.current.isSuccess).toBe(true)
+    expect(result.current.isLoading).toBe(false)
+  })
+
   test('should render correctly with enabled true', async () => {
     const { result, waitForNextUpdate, rerender } = renderHook(
       props => useDataLoader(props.key, props.method, props.config),

diff --git a/packages/use-dataloader/src/useDataLoader.js b/packages/use-dataloader/src/useDataLoader.js
@@ -22,7 +22,7 @@ const useDataLoader = (
     enabled = true,
     reloadOnKeyChange = true,
     keepPreviousData = true,
-  },
+  } = {},
 ) => {
   const {
     addCachedData,