fix: bad condition inside handleRequest (#165)

scaleway · May 10, 2021 · 11cbd72 · 11cbd72
1 parent 4d70fd4
commit 11cbd72
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/packages/use-dataloader/src/__tests__/useDataLoader.test.js b/packages/use-dataloader/src/__tests__/useDataLoader.test.js
@@ -154,10 +154,6 @@ describe('useDataLoader', () => {
     rerender()
     expect(result.current.isLoading).toBe(true)
     expect(result.current.data).toBe(undefined)
-    propsToPass.key = 'new-new-test'
-    rerender()
-    expect(result.current.data).toBe(undefined)
-    expect(result.current.isLoading).toBe(true)
     await waitForNextUpdate()
     expect(result.current.data).toBe(true)
     expect(result.current.isSuccess).toBe(true)

diff --git a/packages/use-dataloader/src/useDataLoader.js b/packages/use-dataloader/src/useDataLoader.js
@@ -83,10 +83,6 @@ const useDataLoader = (
       dispatch(Actions.createOnLoading())
       const result = await methodRef.current?.()
 
-      if (keyRef.current && cacheKey && cacheKey !== keyRef.current) {
-        return
-      }
-
       if (keepPreviousData) {
         previousDataRef.current = getCachedData(cacheKey)
       }