Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #491: Differentiate getter and method with same name #494

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Fix #491: Differentiate getter and method with same name #494

merged 2 commits into from
Jul 10, 2023

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Jul 10, 2023 •
edited
Loading

  • Differentiate getter and method with same name
  • Catch all exceptions in ScalaUnpickler

@adpi2
Copy link
Member Author

adpi2 commented Jul 10, 2023

@aymanelamyaghri you can review these changes if you'd like

aymanelamyaghri
aymanelamyaghri approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@aymanelamyaghri aymanelamyaghri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adpi2 adpi2 linked an issue Jul 10, 2023 that may be closed by this pull request
Exception in call stack #491
Closed
@adpi2 adpi2 merged commit eef3342 into scalacenter:main Jul 10, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanelamyaghri aymanelamyaghri aymanelamyaghri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in call stack
2 participants
@adpi2 @aymanelamyaghri