Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format default values #492

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Format default values #492

merged 3 commits into from
Jul 12, 2023

Conversation

aymanelamyaghri
Copy link
Contributor

No description provided.

adpi2
adpi2 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adpi2
Copy link
Member

adpi2 commented Jul 12, 2023

I forced push to fix the conflict. @aymanelamyaghri If you want to update anything you can do this:

git fetch origin
git reset --hard origin/format-default-values

@adpi2 adpi2 merged commit 58d4e9f into main Jul 12, 2023
9 of 12 checks passed
@aymanelamyaghri aymanelamyaghri deleted the format-default-values branch July 20, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2 adpi2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanelamyaghri @adpi2