Enhance class search #484
Merged
Enhance class search #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iusildra
force-pushed
the
optimize-class-search
branch
2 times, most recently
from
b9d9f74
to
f67886d
Compare
adpi2
reviewed
Jul 7, 2023
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
adpi2
reviewed
Jul 7, 2023
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
adpi2
reviewed
Jul 7, 2023
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
adpi2
reviewed
Jul 7, 2023
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
iusildra
force-pushed
the
optimize-class-search
branch
3 times, most recently
from
d04cda3
to
c44c6db
Compare
adpi2
reviewed
Jul 12, 2023
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceEntrySearchTree.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceLookUpProvider.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceLookUpProvider.scala
Outdated
Show resolved
Hide resolved
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationHelpers.scala
Outdated
Show resolved
Hide resolved
iusildra
force-pushed
the
optimize-class-search
branch
from
c44c6db
to
fcd6297
Compare
iusildra
changed the title
adpi2
reviewed
Jul 13, 2023
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceLookUpProvider.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/Validation.scala
Show resolved
Hide resolved
modules/tests/src/test/scala/ch/epfl/scala/debugadapter/internal/RuntimeEvaluatorTests.scala
Outdated
Show resolved
Hide resolved
use transform for pre-evaluation simplify classes indexing
iusildra
force-pushed
the
optimize-class-search
branch
from
afd3571
to
6fb7848
Compare
iusildra
changed the title
|
I have absolutely no idea of why in Scala 2 there are no breakpoints inside |
adpi2
reviewed
Jul 14, 2023
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/SourceLookUpProvider.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: adpi2 <adrien.piquerez@gmail.com>
adpi2
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize class search with an index
Allow manipulation of classes with special characters in their name (
+,&...)Allow partially qualified class name (e.g.
mutable.Seq)Also fixes #503