Method boxing overloads + added private methods #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iusildra
force-pushed
the
method-boxing-overloads
branch
from
b1790eb
to
9ad27b6
Compare
adpi2
approved these changes
Jun 12, 2023
| @@ -172,7 +172,9 @@ private[internal] class EvaluationProvider( | |||
| compilePrepare(expression, frame).orElse(Success(RuntimeExpression(tree))) | |||
| case Valid(tree) => Success(RuntimeExpression(tree)) | |||
| case Fatal(e) => Failure(e) | |||
| case _: Invalid => compilePrepare(expression, frame) | |||
| case inv: Invalid => | |||
| println(s"\u001b[31mInvalid expression: ${inv.exception}\u001b[0m") | |||
There was a problem hiding this comment.
If you want to log something you should use an instance of ch.epfl.scala.debugadapter.Logger
There was a problem hiding this comment.
it's not really for logging purposes, but for testing. Sometimes I wanted to be sure that the validation failed and not the evaluation
iusildra
force-pushed
the
method-boxing-overloads
branch
from
9ad27b6
to
d2c0f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445
I also removed the filter on private methods, we might want to be able to call them. Extra caution is required when these methods have side effects though