Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime evaluator #405

Merged
merged 20 commits into from
May 24, 2023
Merged

Runtime evaluator #405

merged 20 commits into from
May 24, 2023

Conversation

iusildra
Copy link
Contributor

@iusildra iusildra commented Apr 13, 2023 •
edited
Loading

Goal: make an evaluator that would evaluate an expression with reflection by using jdi and scalameta

How it should work:

  1. Parse the expression into a tree using scalameta
  2. Validate the expression by traversing the scalameta tree, and generating a new tree containing references and any relevant information (arguments, qualifier...) of the corresponding element (or only their name and types if it depends on the current frame), that can be used to cache the expression
    • name resolution (local variable, fields, modules, classes...)
    • method resolution (apply calls, non-generic overloads resolution)
    • type checking (works only on non-generic types because of erasure)
  3. Evaluate the expression using the tree generated during the validation

Because of some overloads resolution or access to private field during the debug session, one evaluation mode might fail but not the other, so there must be some priorities:

@iusildra iusildra force-pushed the runtime-evaluator branch 2 times, most recently from 06b541d to 54c446e Compare April 20, 2023 13:52
@iusildra iusildra force-pushed the runtime-evaluator branch 5 times, most recently from aecbb32 to a277b39 Compare May 11, 2023 07:23
adpi2
adpi2 reviewed May 11, 2023
View reviewed changes
modules/core/src/main/scala/ch/epfl/scala/debugadapter/DebugConfig.scala Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/EvaluationProvider.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/EvaluationProvider.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiClassLoader.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiClassLoader.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiClassLoader.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiObject.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/JdiValue.scala Outdated Show resolved Hide resolved
...s/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/PreparedExpression.scala Outdated Show resolved Hide resolved
...ore/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationTree.scala Outdated Show resolved Hide resolved
adpi2
adpi2 reviewed May 11, 2023
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

adpi2
adpi2 reviewed May 11, 2023
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments

...ore/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationTree.scala Outdated Show resolved Hide resolved
...ore/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationTree.scala Outdated Show resolved Hide resolved
...ore/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationTree.scala Outdated Show resolved Hide resolved
...ore/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationTree.scala Outdated Show resolved Hide resolved
...ore/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationTree.scala Outdated Show resolved Hide resolved
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluatorPatterns.scala Outdated Show resolved Hide resolved
...ore/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationTree.scala Outdated Show resolved Hide resolved
...s/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimePrimitiveOp.scala Outdated Show resolved Hide resolved
...s/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimePrimitiveOp.scala Show resolved Hide resolved
...s/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimePrimitiveOp.scala Outdated Show resolved Hide resolved
adpi2
adpi2 reviewed May 11, 2023
View reviewed changes
...s/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimePrimitiveOp.scala Outdated Show resolved Hide resolved
...s/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimePrimitiveOp.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/ValidationMonad.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/ValidationMonad.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/ValidationMonad.scala Outdated Show resolved Hide resolved
modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/package.scala Outdated Show resolved Hide resolved
...les/tests/src/test/scala/ch/epfl/scala/debugadapter/internal/JavaRuntimeEvaluatorTests.scala Outdated Show resolved Hide resolved
...test/scala/ch/epfl/scala/debugadapter/internal/RuntimeEvaluatorPrimitiveOperationTests.scala Outdated Show resolved Hide resolved
modules/tests/src/test/scala/ch/epfl/scala/debugadapter/internal/RuntimeEvaluatorTests.scala Outdated Show resolved Hide resolved
adpi2
adpi2 reviewed May 12, 2023
View reviewed changes
.../src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluatorPatterns.scala Outdated Show resolved Hide resolved
modules/tests/src/test/scala/ch/epfl/scala/debugadapter/BypassExpressionCompilerTests.scala Show resolved Hide resolved
...les/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluator.scala Outdated Show resolved Hide resolved
...ore/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluationTree.scala Outdated Show resolved Hide resolved
...les/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluator.scala Outdated Show resolved Hide resolved
...les/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluator.scala Outdated Show resolved Hide resolved
...les/core/src/main/scala/ch/epfl/scala/debugadapter/internal/evaluator/RuntimeEvaluator.scala Outdated Show resolved Hide resolved
@iusildra iusildra force-pushed the runtime-evaluator branch 3 times, most recently from 167e307 to 9132c9d Compare May 22, 2023 08:04
iusildra and others added 10 commits May 22, 2023 10:13
@iusildra
feat: runtime validation & evaluation
aceaf22 
feat: more complex apply, inheritance partially handled

feat: find implicit .apply() calls

fix: cross compile error

saving

runtime validator

feat: Added runtime case errors. Added qualifiers to runtime tree nodes

fix: removed duplicates in RuntimeEvaluator

some refactoring & basic module resolution

fix: syntax
fix: tests & type component extraction

fix: evaluate any module if already instantiated

fix: .only :'(

looking for error

found it: wrong comparison =D

temporary: use latest version of sbt for the ci to pass

grouped tests by feature and splitted source

feat: evaluate inner & nested types

fix: module resolution

fix: split select and apply validation

removed useless code + defined validation-specific monad

finished applying validation monad, evaluation type ordering

feat: new call evaluation 1/2 + class lookup fix for scala 2

looking for errors bis

looking for errors (forgot some prints)

printy printy

we love print

one last time

cross-compile error x)

found it ?

found error + began checking Java expressions evaluation

feat: runtime validation & evaluation

feat: migrating to the new jdi classes & minor optimization for class lookup

fix: syntax cross compatibility

fix: java syntax warning-error

added tests for static method calls

fix: java syntax warning-error

fix: primitive evaluation 1/n

feat: primitive method evaluation

fix: removed uneeded scalameta deps, fixed sbt plugin error

refactoring

fix: changed deprecated converter + removed unneeded conversions

feat: primitive equality

placed primitive operations tests in separate file. Inlined auxiliary methods

fix: allow unboxable type in primitive operation + load classes on need
@adpi2 @iusildra
merged main into runtime-evaluator
f948810
@iusildra
refactoring + class not loaded & primitive boolean op bug fix
630186f
@iusildra
replaced simple evaluator by runtime evaluator
00e3ef1
@iusildra
fix: removed inline annotations
c810e3b
@iusildra
applied review comments
3fd1f09 
fix: recover by looking for classes in static context

fix: applied requested changes 1.5/2

fix: removed access to instance members via static

applied changes 1.75/2, added some docs, fixed nested types resolutions

applied review comments, fixed == operator
@iusildra
feat: primitive unary methods + removed unneeded comments
04bef39
@iusildra
feat: outer fields/methods evaluation
0342ab0
@iusildra
fix: module evaluation
3e0395c 
fix: module evaluation
@iusildra
splitted runtime evaluator in separate class
2b9c984
@iusildra iusildra linked an issue May 23, 2023 that may be closed by this pull request
Evaluate expression using scalameta in the debugger scalacenter/student-projects#9
Closed
@iusildra iusildra marked this pull request as ready for review May 24, 2023 07:03
adpi2
adpi2 approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @iusildra!

@iusildra iusildra merged commit 419c5ee into scalacenter:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2 adpi2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluate expression using scalameta in the debugger
2 participants
@iusildra @adpi2