Fixes retrieval of ModuleComponentIdentifier
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the Bloop plugin wouldn't work at all in a private repository using a proprietary version of Gradle. I believe this is because the presence of a certain plugin that was interfering and changing the artifacts available after resolution to be something else than `ModuleComponentArtifactIdentifier`, so the Scala plugin would never collect the Scala library. But, the result was that the Bloop plugin wouldn't generate Bloop files and it would fail altogether. The following change, which is untested because I couldn't reproduce, has a fix that uses a more general interface `ModuleComponentIdentifier` and pattern matches on `getComponentIdentifier` instead of the regular artifact identifiers. This seems to be the most correct and general way of writing the previous logic.
|
If it passes the tests then LGTM. I'm never sure of the correct way of doing anything with the Gradle API 🤷 |
adpi2
reviewed
Oct 31, 2023
|
@adpi2 Could you also please cut a release after merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the Bloop plugin wouldn't work at all in a private repository using a proprietary version of Gradle. I believe this is because the presence of a certain plugin that was interfering and changing the artifacts available after resolution to be something else than
ModuleComponentArtifactIdentifier, so the Scala plugin would never collect the Scala library. But, the result was that the Bloop plugin wouldn't generate Bloop files and it would fail altogether.The following change, which is untested because I couldn't reproduce, has a fix that uses a more general interface
ModuleComponentIdentifierand pattern matches ongetComponentIdentifierinstead of the regular artifact identifiers. This seems to be the most correct and general way of writing the previous logic.