Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -Xnojline option when starting console #468

Merged
merged 1 commit into from
May 3, 2018
Merged

Use -Xnojline option when starting console #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/main/scala/bloop/engine/tasks/Tasks.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ object Tasks {
val loader = ClasspathUtilities.makeLoader(classpathFiles, scalaInstance)
val compiler = state.compilerCache.get(scalaInstance).scalac.asInstanceOf[AnalyzingCompiler]
val classpathOptions = ClasspathOptionsUtil.repl
compiler.console(classpathFiles, project.scalacOptions, classpathOptions, "", "", state.logger)(
val options = project.scalacOptions :+ "-Xnojline"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to use a constant here, but scala.tools.nsc.settings.ScalaSettings has no companion object and I don't think that creating our own instance just to extract this value makes much sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag is unlikely to change, so I don't think it's a big deal 👍

compiler.console(classpathFiles, options, classpathOptions, "", "", state.logger)(
Some(loader))
state
}
Expand Down