Upgrade directories version to match coursier's #465
Conversation
jvican
changed the title
|
Hey, coursier switched to version 10 of directories in v1.1.0-M2, is there a reason you hold on to 7? |
There was a problem hiding this comment.
Looks good 🙂 But as @avdv suggested, maybe we could upgrade to version 10 as there seem to be quite a few bugs in versions <= 7? Coursier 1.1.0-M1 uses version 6, but AFAIK we're using coursier's master branch anyway.
Also, should we consider setting qualifier/organisation name as well? Qualifier affects only Mac, while organisation affects Mac and Windows. I don't know how important they are on those systems - probably it's just cosmetic so not worth changing now, I guess?
|
@tues Thanks for the review 😉. 👍 on your suggestion to upgrade to 10, guys.
I didn't change it because it would modify the path of the bloop cache. That means that users in the systems affected (mainly osx and windows) will need to see how the compilation bridges are compiled again, and that may be annoying. I don't own a Mac or Windows, are the qualifier and organisation important for a correct behaviour upon the creation of these directories? |
This issue just showed up in the windows tests. It was an oversight that our `sources` was giving us all the source in the source dirs too. We only want to export those sources that are not contained in the source dirs.
|
Not sure about Windows, but on Mac all it seems to do is prepending program name with dot-separated qualifier name and apparently not all Mac programs do that. Since I don't use Mac for development either I have asked a friend who is using both Bloop and Mac and he confirmed that everything is working fine and e.g. IntelliJ is even misusing the standard by creating I guess this is worth a new release considering that installing Bloop using the official guide isn't working now? P.S. I know you probably don't need reviews, but I hope they don't do any harm? 😉 |
|
Thanks for confirming! Yeah, we'll try to release a new version soon. Need to write the release notes.
Absolutely not, feel free to submit your reviews 😉 |
Fixes #463.