Add Dotty support #460
Merged
Add Dotty support #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
approved these changes
May 1, 2018
Duhemm
force-pushed
the
topic/dotty-support
branch
from
a2c2a1a
to
03fccd8
Compare
jvican
added a commit
that referenced
this pull request
Oct 6, 2019
#460 initially added support for Dotty but we removed it recently while experimenting with some breaking changes in the Zinc compiler interface. Those changes were afterwards refactored to be non-breaking with the Dotty compiler bridge, which means Dotty continues to work with Bloop. However, we must need a change in the Dotty compiler interface to support invalidation of class files by hooking up into their compiler symbol loaders. I'll follow up with that change in the Dotty repository.
Merged
jvican
added a commit
that referenced
this pull request
Oct 6, 2019
#460 initially added support for Dotty but we removed it recently while experimenting with some breaking changes in the Zinc compiler interface. Those changes were afterwards refactored to be non-breaking with the Dotty compiler bridge, which means Dotty continues to work with Bloop. However, we must need a change in the Dotty compiler interface to support invalidation of class files by hooking up into their compiler symbol loaders. I'll follow up with that change in the Dotty repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #74
I only had to fix
def hasScalaCompilerNamefrom your previous PR.