-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp the test and run fork process infrastructure #449
Merged
Commits on May 1, 2018
-
Inherit process input stream from Bloop
Otherwise, `System.console() == null`.
Configuration menu - View commit details
-
Copy full SHA for dcda31f - Browse repository at this point
Copy the full SHA dcda31fView commit details -
Revamp the test and run fork process infrastructure
1. Migrate to `NuProcess` and avoid the annoying Java and Scala process APIs. Nuprocess gives us a better foundation to deal with stdout and stderr, as well as processing standard input from the host process (Bloop). `NuProcess` will also be more efficient than our previous approach. 2. Migrate test server and the whole `runMain` machinery to `Task` so that we can have a finer control over it. Note that now these actions can be cancelled!
Configuration menu - View commit details
-
Copy full SHA for 15d2176 - Browse repository at this point
Copy the full SHA 15d2176View commit details -
It fails spuriously with good reason: Bloop doesn't yet support concurrent clients. When we do, we'll re-enable this test suite.
Configuration menu - View commit details
-
Copy full SHA for 8ffc937 - Browse repository at this point
Copy the full SHA 8ffc937View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba8e3ea - Browse repository at this point
Copy the full SHA ba8e3eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 984f29b - Browse repository at this point
Copy the full SHA 984f29bView commit details -
Upgrade nuProcess and modernize nailgun test
The modernization makes sure that: 1. All processes that call bloop do provide an empty or inherited input stream in both the server part and the client part. 2. The implementation is task based so that we can remove the annoying thread sleep + have automatic shutdown of the processes if the timeout is not met.
Configuration menu - View commit details
-
Copy full SHA for b37ea71 - Browse repository at this point
Copy the full SHA b37ea71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51455d5 - Browse repository at this point
Copy the full SHA 51455d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a336542 - Browse repository at this point
Copy the full SHA a336542View commit details -
Configuration menu - View commit details
-
Copy full SHA for 060b7d4 - Browse repository at this point
Copy the full SHA 060b7d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ae0e49 - Browse repository at this point
Copy the full SHA 6ae0e49View commit details
Commits on May 2, 2018
-
Don't return from the client until nailgun server is down
I think this is one of the reasons why our nailgun-based test infrastructure has been traditionally not very stable. Let's see if this fixes it.
Configuration menu - View commit details
-
Copy full SHA for 42d0f10 - Browse repository at this point
Copy the full SHA 42d0f10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3175510 - Browse repository at this point
Copy the full SHA 3175510View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.