Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue the bsp implementation #431

Merged
merged 24 commits into from
Apr 12, 2018
Merged

Commits on Apr 10, 2018

  1. Add bsp test for compile

    jvican committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    71366f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54197be View commit details
    Browse the repository at this point in the history
  3. Don't log BSP protocol using logback

    Reuse the new infrastructure using Bloop loggers via Slf4jAdapter.
    
    On top of that, in case there's an error in a BSP test case, we report
    *all* the logs reported by both the client and the server to help
    diagnose problems.
    jvican committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    1e92164 View commit details
    Browse the repository at this point in the history
  4. Get rid of logback configuration

    Yay! Goodbye XML.
    jvican committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    a5c97dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aab017d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    76a213f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    98dc5ab View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ba7e10a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f61e977 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a381093 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d412118 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2d2febf View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    49b40dc View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    58c90b7 View commit details
    Browse the repository at this point in the history
  15. Make the build target to compile deterministic

    In Windows, the order was different than in Linux and was picking up
    `root`, which has no sources and therefore can never compile and output
    'Done compiling'.
    jvican committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    08c8607 View commit details
    Browse the repository at this point in the history
  16. Use our slf4j logger in directory-watcher

    Read gmethvin/directory-watcher#12 for all the
    context.
    jvican committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    e8fb434 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2018

  1. Make results cache aware of previous compilations

    (including the failed ones).
    
    This is what this commit does:
    
    1. `ResultsCache` no longer stores the successful previous results. Now
    it also stores the `Compiler.Result`s, so that a state that has been
    compiled allows us to derive summaries and now how the compilation was.
    This includes being able to tell the user why a given project was not
    compiled (because it was blocked by other ones). This is important to
    return a `CompileReport` in bsp-land, but that's implemented in another
    PR.
    
    2. The `Result` ADT is moved to backend, `Success` now takes the
    reporter too (to check how many error or warnings were outputted to the
    user's log), and a reporter is derived from the source infos of previous
    Zinc results.
    
    3. The `Result` ADT no longer takes the project as a paramter, instead
    we get the project from the `toCompileTask` in `Tasks.scala`.
    jvican committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    76968fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1b96da9 View commit details
    Browse the repository at this point in the history
  3. Move bloop.reporter to backend instead of frontend

    Frontend is becoming bloated and reporter utils have no specific
    dependency in frontend, therefore we're moving them to backend.
    jvican committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    e908382 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0d5ffd5 View commit details
    Browse the repository at this point in the history
  5. Disable ansii color codes for bsp clients

    BSP clients needed to escape the ansii color codes manually. In order to
    avoid this unnecessary work, we default to no ansii color codes for now.
    In the future, we will enrich the spec with a flag to toggle ansii color
    codes.
    jvican committed Apr 11, 2018
    Configuration menu
    Copy the full SHA
    decd99b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. Implement DAG logic to deduplicate targets based on deps

    See the Scaladoc in `Dag.reduce`. This will allow us to implement
    #217 efficiently.
    jvican committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    c6f3f3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1821c52 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1e52776 View commit details
    Browse the repository at this point in the history