Generalize sourceDirectories to sources
#425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rberenguel
approved these changes
Apr 8, 2018
jvican
force-pushed
the
topic/allow-source-files
branch
from
1ea56ec
to
bbb13f5
Compare
Duhemm
approved these changes
Apr 8, 2018
jvican
force-pushed
the
topic/allow-source-files
branch
from
bbb13f5
to
0acffcc
Compare
|
@Duhemm There's no new logic 😉 |
Our project abstraction only accepted source directories. This limitation is unfounded and makes it difficult to support build tools whose project definitions have no source directories. One example of such a build tool is Bazel, whose `Target`s only know about source files. This patch: 1. Renames `sourceDirectories` in the source code. 2. Makes the rest of the code (`Tasks` and `SourceWatcher`) aware that sources does not strictly mean directories. 3. Build upon @rberenguel's work to show the same "Watching ..." message in every watch iteration.
jvican
force-pushed
the
topic/allow-source-files
branch
from
0acffcc
to
c1297b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our project abstraction only accepted source directories. This
limitation is unfounded and makes it difficult to support build tools
whose project definitions have no source directories. One example of
such a build tool is Bazel, whose
Targets only know about sourcefiles.
This patch:
sourceDirectoriesin the source code.TasksandSourceWatcher) aware thatsources does not strictly mean directories.
in every watch iteration.