-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/watch waiting for #422 #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this patchk, and congrats on your first contribution 🎉!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that a better place to add this log would be right after we clear the screen:
@jvican but that log there makes no sense, since the screen is cleaned before the test is run, when it appears nothing is actually watched for change then. Also, the output from the tests would wipe it out so the situation would still be the same as what @olafurpg reports. The only place that can show the message after the action has been executed and we are watching for the next changes (and not requiring some rewrite of the actual actions) is where I put it, unless there's some task chaining I'm not aware of with Monix (never used it, so may be the case) |
You're right Ruben, I thought we were clearing the screen right after the compilation is finished, but we only do it when there's a new event. 👍 |
Thanks @jvican awesome work you (I mean you and the rest of the contributors and maintainers) have with bloop. Not only because it's very fast (wish I'd known about it before!), but the code base is easy to follow and the documentation (for users and contributors) is very clear. Doesn't happen everywhere! |
@Duhemm and I are very happy to hear that. Thanks for the nice words! |
Log watching status after state change.
Fixes #422.