Add improvements to sbt plugin and migrate to .bloop
#411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that our `integrationSetUpBloop` was displaying logs with the paths shortened, when they shouldn't because all the configuration files are written in the staging sbt directory (because they are source deps). This commit fixes it.
Duhemm
reviewed
Mar 29, 2018
| @@ -60,6 +60,7 @@ object PluginImplementation { | |||
| // We create build setting proxies to global settings so that we get autocompletion (sbt bug) | |||
| val buildSettings: Seq[Def.Setting[_]] = List( | |||
| BloopKeys.bloopInstall := BloopKeys.bloopInstall.in(Global).value, | |||
| // Bloop users: Do NEVER override this setting as a user if you want it to work | |||
There was a problem hiding this comment.
This should probably be in the documentation, no?
There was a problem hiding this comment.
We don't have docs for this yet. Do you want me to add them?
jvican
force-pushed
the
topic/fix-export-sbt
branch
4 times, most recently
from
9b7ce82
to
6ca16d7
Compare
jvican
added
enhancement
docs
integrations
install
configuration format
From now on, every configuration directory in the community build has the schema version embedded in the path to prevent copy-pasting issues when the caches are regenerated for new configuration format changes.
jvican
force-pushed
the
topic/fix-export-sbt
branch
from
6ca16d7
to
709cd49
Compare
jvican
changed the title
.bloop
jvican
changed the title
.bloop.bloop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that our
integrationSetUpBloopwas displaying logs with thepaths shortened, when they shouldn't because all the configuration files
are written in the staging sbt directory (because they are source deps).
This commit fixes it.