Propagate error to avoid downstream execution #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
added
bug
Duhemm
approved these changes
Mar 14, 2018
| excludeRoot: Boolean | ||
| )(next: State => Task[State]): Task[State] = { | ||
| Tasks.compile(state, project, reporterConfig, excludeRoot).flatMap { compiled => | ||
| if (compiled.status != ExitStatus.CompilationError) next(compiled) |
There was a problem hiding this comment.
Shouldn't we only continue if the status is Ok?
There was a problem hiding this comment.
I'm a little bit afraid of doing that now because of #195 and other errors we've had in this area (which is probably the less tested overall in bloop), so I'd prefer to keep it this way for now.
|
Drone didn't run... |
As the compilation task does not throw an exception, but rather we model failures in the DAG, we need to propagate the error down the task dependency chain so that tasks that depend on compilation do not continue if compilation has failed. In this vein, this commit aligns the codebase to behave like this, and then avoid testing a project that has not correctly compiled.
jvican
force-pushed
the
topic/propagate-compilation-error
branch
from
e9771fb
to
e168ca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the compilation task does not throw an exception, but rather we model
failures in the DAG, we need to propagate the error down the task
dependency chain so that tasks that depend on compilation do not continue
if compilation has failed.
In this vein, this commit aligns the codebase to behave like this, and then
avoid testing a project that has not correctly compiled.