Remove log4j #328
Merged
Remove log4j #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvican
approved these changes
Mar 12, 2018
| .build() | ||
|
|
||
| appender | ||
| private def printTrace(line: String): Unit = { |
There was a problem hiding this comment.
Shall we add a method for Throwable here?
There was a problem hiding this comment.
Oh no, just realized that the method targeting Throwable comes inherited.
jvican
reviewed
Mar 12, 2018
| outAppender.start() | ||
| errAppender.start() | ||
| private def print(msg: String, fn: String => Unit): Unit = { | ||
| if (msg == null) () |
There was a problem hiding this comment.
This implementation is pretty weird. why .lines and why the NPE guard? Is there a way we can remove that from this core logging API endpoint?
There was a problem hiding this comment.
.lines is to have the prefix on every line (think log.error("foo\nbar")). The NPE guard is to make sure .lines won't crash. There are cases where exception.getMessage is null.
jvican
approved these changes
Mar 12, 2018
| assertTrue("`logger2` received messages of `logger1`", | ||
| !msgs2.exists(_.startsWith("Compiling"))) | ||
| assertTrue("`logger2` received verbose messages of `logger1`", | ||
| !msgs2.exists(_.startsWith(debugPrefix))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.