Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Forward standard output to logger #2361

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 28, 2024

@tgodzik
Copy link
Contributor Author

tgodzik commented Jul 16, 2024

The biggest issue with this approach is that we might be getting wrong compiler messages (from concurrent compilation) if compiling a couple of things at the same time. On the other hand, it would really be a rare scenario where we would get printlns from compiler at the same time for different clients as normal compilation does not do it. This should not cause real issues especially that nowadays Bloop really just works with one.

@tgodzik tgodzik requested a review from adpi2 July 17, 2024 13:56
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like it but I guess we don't have a choice. It would be nice if the compiler uses the logger to print those trees.

@tgodzik
Copy link
Contributor Author

tgodzik commented Aug 6, 2024

I don't really like it but I guess we don't have a choice. It would be nice if the compiler uses the logger to print those trees.

Good news is that with the recent changes this is only an issue if the same user compiles with additional print options two projects at the same time. Which should be super rare.

@tgodzik tgodzik requested a review from adpi2 August 6, 2024 14:47
@tgodzik
Copy link
Contributor Author

tgodzik commented Aug 7, 2024

I will merge this after 2.0.0 just to be on the safe side

@tgodzik tgodzik merged commit 3fdeacf into scalacenter:main Aug 15, 2024
14 checks passed
@tgodzik tgodzik deleted the print-out branch August 15, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants