Update scala-debug-adpater to 4.x and add support for hot code replace #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Feb 19, 2024
| private val previousAnalysis: AtomicReference[CompileAnalysis] = new AtomicReference() | ||
| private val classesSubject: PublishSubject[Seq[String]] = PublishSubject() | ||
|
|
||
| def observable: Observable[Seq[String]] = classesSubject |
There was a problem hiding this comment.
One thing that worries me is that we will want to replace monix at some point. Do you know if there is a cats effect equivalent that we can use?
There was a problem hiding this comment.
I don't know for cats-effect but there is a reactivex equivalent and it already is a transitive dependency of Bloop brought by the scala-debug-adapter. Also I saw some other usages of monix obersvable/observers elsewhere in Bloop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new 4.x version of the scala-debug-adpater brings:
See the release notes for more information.
For the hot code replace we need Bloop to call the
onClassUpdatecallback each time some classes change or new classes are created. This PR implements it by introducing theClientClassesObserver. It compares the newCompileAnalysiswith the previous one to know which classes need to be reloaded and then it calls theonClassUpdatecallback.