Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-bloop and buildpress don't depend on launcher #1751

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

alexarchambault
Copy link
Contributor

It seems these are spurious dependencies (maybe these are there for historical reasons?). sbt-bloop only needs bloop-config, and buildpress is fine with just bloopgun and bloop-shared.

@alexarchambault
Copy link
Contributor Author

(It seems I can't re-run the failing CI jobs myself, but the errors look transient, and definitely unrelated to the changes here.)

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So of that might been made irrelevant by the changes related to Zinc

@tgodzik tgodzik merged commit 68105d9 into scalacenter:main Jul 5, 2022
@alexarchambault alexarchambault deleted the less-launcher-dependees branch July 5, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants