Exract `classpathOptions` in sbt-bloop #110

Duhemm · 2017-12-01T20:07:02Z

No description provided.

Duhemm · 2017-12-01T22:34:20Z

That's a genuine failure, but I can't reproduce it on my machine...

Duhemm · 2018-01-19T16:42:34Z

I couldn't reproduce the failure on my machine then, and I still can't. Hopefully it'll work now!

jvican · 2018-01-22T09:59:16Z

@Duhemm Did you eventually print classpaths here to see how classpathOptions is making a difference?

Duhemm · 2018-01-22T10:00:07Z

It's on today's list :)

jvican · 2018-01-30T13:08:55Z

Has the mistery been solved? We may want to find a sorcerer to help us find out what's happening.

Duhemm · 2018-02-08T09:20:05Z

Debug info shows that this is extremely likely to be caused by our integration tests setup: several entries of the classpath and boot classpath do no exists when we do the compilation, because they're downloaded in scripted when we do the setup.

Let's see if sharing the same ivy home for scripted and normal sbt solves the issue.

Duhemm · 2018-02-19T16:34:02Z

I'm pretty sure it didn't run the community build

@jvican Do you know why?

Duhemm · 2018-02-20T06:00:23Z

Nevermind, I had forgotten about your PR that fixes it :)

Duhemm · 2018-02-26T06:03:22Z

test performance please

bloopoid · 2018-02-26T06:04:19Z

performance test scheduled: 1 job(s) in queue, 0 running.

bloopoid · 2018-02-26T14:17:39Z

Performance test finished successfully.

Benchmarks is based on merging with master

jvican · 2018-02-27T14:25:15Z

Any news on this? 😄

Duhemm · 2018-02-27T14:27:16Z

Yes, it works. It crashed because it had the wrong configurations (hence the NPEs).

jvican

Looks good, I'd like to run the benchmarks on this before merging. I've left three comments I think are important addressing before merging.

jvican · 2018-03-08T09:28:39Z

frontend/src/test/scala/bloop/tasks/IntegrationTestSuite.scala

@@ -70,7 +73,11 @@ class IntegrationTestSuite(testDirectory: Path) {
        (state, rootProject)
    }

-    val reachable = Dag.dfs(state.build.getDagFor(projectToCompile)).filter(_ != projectToCompile)
+    val reachable =


Why is this necessary?

I renamed state to initialState, and state is now the state after cleaning. We need to clean because the project may have already been compiled by a previous test.

jvican · 2018-03-08T09:29:41Z

integrations/maven-bloop/src/main/java/bloop/integrations/maven/BloopMojo.java

@@ -35,6 +37,21 @@
    @Parameter(property = "bloop.executionFork", defaultValue = "false")
    private boolean bloopExecutionFork;

+    @Parameter(property = "bloop.classpathOptions.bootLibrary", defaultValue = "true")


Have you looked if the maven integration already supports all these?

I've been through the plugin but I haven't found how this could be configured, so I assumed it didn't.

Can you double-check?

jvican · 2018-03-08T09:31:12Z

frontend/src/main/scala/bloop/Project.scala

@@ -96,6 +99,12 @@ object Project {
      ScalaInstance(scalaOrganization, scalaName, scalaVersion, allScalaJars, logger)
    val classpath = toPaths(properties.getProperty("classpath"))
    val classesDir = toPath(properties.getProperty("classesDir"))
+    val classpathOptions = {
+      val values = properties.getProperty("classpathOptions").split(",")
+      val Array(bootLibrary, compiler, extra, autoBoot, filterLibrary) =


The error reporting if this fails is poor here.

jvican · 2018-03-08T09:31:29Z

bin/detect-community-build.sh

+    exit 0
+  else
+    echo "The community build will not run for this pull request."
+    exit 1


Doesn't this mean that Drone will fail altogether?

Good catch, the problem was actually in .drone.yml

jvican · 2018-03-08T09:36:41Z

backend/src/main/scala/bloop/CompilerCache.scala

@@ -15,13 +15,14 @@ class CompilerCache(componentProvider: ComponentProvider,
                    logger: Logger,
                    userResolvers: List[Resolver]) {

-  private val cache = new ConcurrentHashMap[ScalaInstance, Compilers]()
+  private type CompilerID = (ScalaInstance, ClasspathOptions)
+  private val cache = new ConcurrentHashMap[CompilerID, Compilers]()


Why is this necessary? It's not clear to me why classpath options is part of the compiler key, this is not nice performance wise because every time the classpath options change we need to instantiate a new compiler. Can we avoid this change?

The classpathOptions are part of the parameters that we give Zinc to get a Compilers instance. I'll try to work around that...

jvican · 2018-03-08T10:39:45Z

.drone.yml

-        *[DOCS]*) echo "Skipping tests for commit that only changes docs." ;;
-        *) ${SBT_RUN}; ./bin/ci-clean-cache.sh ;;
-        esac
+      - if [[ "$DRONE_COMMIT_MESSAGE" == *[DOCS]* ]]; then


This fails in sh, that's why it's implemented via case

jvican · 2018-03-09T16:42:22Z

If you want to regenerate the configuration files, you need to update the version number of the configuratino file in our build, you can drop 4fe1988

Duhemm force-pushed the topic/extract-classpathoptions branch from 23561dc to 84ffca7 Compare December 5, 2017 10:33

Duhemm mentioned this pull request Dec 12, 2017

Remove scalajars from the classpath #130

Closed

jvican added this to the Bloop 0.1 milestone Dec 12, 2017

Duhemm force-pushed the topic/extract-classpathoptions branch from 84ffca7 to 2a210dd Compare January 19, 2018 16:34

Duhemm force-pushed the topic/extract-classpathoptions branch from 2a210dd to e45babb Compare February 6, 2018 15:19

Duhemm force-pushed the topic/extract-classpathoptions branch 2 times, most recently from c6968fe to 6aee219 Compare February 8, 2018 09:24

jvican force-pushed the master branch 2 times, most recently from 3883387 to 21a8dc9 Compare February 9, 2018 15:08

Duhemm force-pushed the topic/extract-classpathoptions branch from 6aee219 to 2042b53 Compare February 10, 2018 19:39

Duhemm added the community-build label Feb 10, 2018

Duhemm force-pushed the topic/extract-classpathoptions branch 2 times, most recently from fca0537 to 88bb1ef Compare February 19, 2018 16:22

Duhemm mentioned this pull request Feb 20, 2018

Add a random change to try the community build #247

Closed

Duhemm force-pushed the topic/extract-classpathoptions branch from d5461ee to 5c37551 Compare February 26, 2018 06:02

Duhemm force-pushed the topic/extract-classpathoptions branch 2 times, most recently from 4c64091 to 402596d Compare March 8, 2018 08:55

Duhemm force-pushed the topic/extract-classpathoptions branch from 402596d to c28c757 Compare March 8, 2018 09:01

jvican suggested changes Mar 8, 2018

View reviewed changes

jvican reviewed Mar 8, 2018

View reviewed changes

Duhemm force-pushed the topic/extract-classpathoptions branch from 881009b to 4fe1988 Compare March 9, 2018 08:09

jvican added the bug A defect or misbehaviour. label Mar 14, 2018

Duhemm force-pushed the topic/extract-classpathoptions branch from 4fe1988 to 3ece4db Compare March 16, 2018 12:58

Duhemm force-pushed the topic/extract-classpathoptions branch 2 times, most recently from 35841c2 to 6ea16fa Compare March 27, 2018 13:55

jvican force-pushed the topic/extract-classpathoptions branch from 6ea16fa to 8b7e16d Compare March 27, 2018 14:35

Duhemm added 3 commits March 27, 2018 17:09

Extract classpath options in maven and sbt

ffe63ef

Bump schema version

c8e69a5

Mention classpath options in release notes

aa87faf

jvican force-pushed the topic/extract-classpathoptions branch from 8b7e16d to aa87faf Compare March 27, 2018 15:09

jvican approved these changes Mar 27, 2018

View reviewed changes

jvican added the configuration format Assigned to any ticket or pull request that will change the configuration file format. label Mar 27, 2018

Refresh configuration file format

11f4902

jvican merged commit 0def412 into master Mar 27, 2018

tgodzik deleted the topic/extract-classpathoptions branch September 7, 2021 16:19

tgodzik pushed a commit to tgodzik/bloop that referenced this pull request Jul 5, 2023

Clean-up CI jobs (scalacenter#110)

c44598a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exract `classpathOptions` in sbt-bloop #110

Exract `classpathOptions` in sbt-bloop #110

Duhemm commented Dec 1, 2017

Duhemm commented Dec 1, 2017

Duhemm commented Jan 19, 2018

jvican commented Jan 22, 2018 •

edited

Loading

Duhemm commented Jan 22, 2018

jvican commented Jan 30, 2018

Duhemm commented Feb 8, 2018

Duhemm commented Feb 19, 2018

Duhemm commented Feb 20, 2018

Duhemm commented Feb 26, 2018

bloopoid commented Feb 26, 2018

bloopoid commented Feb 26, 2018

jvican commented Feb 27, 2018

Duhemm commented Feb 27, 2018

jvican left a comment

jvican Mar 8, 2018

Duhemm Mar 8, 2018

jvican Mar 8, 2018

Duhemm Mar 8, 2018

jvican Mar 8, 2018

jvican Mar 8, 2018

jvican Mar 8, 2018

Duhemm Mar 8, 2018

jvican Mar 8, 2018

Duhemm Mar 8, 2018

jvican Mar 8, 2018

jvican commented Mar 9, 2018

Exract classpathOptions in sbt-bloop #110

Exract classpathOptions in sbt-bloop #110

Conversation

Duhemm commented Dec 1, 2017

Duhemm commented Dec 1, 2017

Duhemm commented Jan 19, 2018

jvican commented Jan 22, 2018 • edited Loading

Duhemm commented Jan 22, 2018

jvican commented Jan 30, 2018

Duhemm commented Feb 8, 2018

Duhemm commented Feb 19, 2018

Duhemm commented Feb 20, 2018

Duhemm commented Feb 26, 2018

bloopoid commented Feb 26, 2018

bloopoid commented Feb 26, 2018

jvican commented Feb 27, 2018

Duhemm commented Feb 27, 2018

jvican left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jvican commented Mar 9, 2018

Exract `classpathOptions` in sbt-bloop #110

Exract `classpathOptions` in sbt-bloop #110

jvican commented Jan 22, 2018 •

edited

Loading