Use -Xnojline option when starting console #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using Nailgun, the REPL is being run in a different process than the one connected to the user's terminal, so we cannot run Scala's ILoop with InteractiveReader - we must use SimpleReader instead. By passing -Xnojline argument to AnalyzingCompiler.console we make sure that it will use SimpleReader. Fixes scalacenter#385.
tues
commented
May 3, 2018
| @@ -212,7 +212,8 @@ object Tasks { | |||
| val loader = ClasspathUtilities.makeLoader(classpathFiles, scalaInstance) | |||
| val compiler = state.compilerCache.get(scalaInstance).scalac.asInstanceOf[AnalyzingCompiler] | |||
| val classpathOptions = ClasspathOptionsUtil.repl | |||
| compiler.console(classpathFiles, project.scalacOptions, classpathOptions, "", "", state.logger)( | |||
| val options = project.scalacOptions :+ "-Xnojline" | |||
There was a problem hiding this comment.
I'd love to use a constant here, but scala.tools.nsc.settings.ScalaSettings has no companion object and I don't think that creating our own instance just to extract this value makes much sense.
There was a problem hiding this comment.
The flag is unlikely to change, so I don't think it's a big deal 👍
jvican
approved these changes
May 3, 2018
| @@ -212,7 +212,8 @@ object Tasks { | |||
| val loader = ClasspathUtilities.makeLoader(classpathFiles, scalaInstance) | |||
| val compiler = state.compilerCache.get(scalaInstance).scalac.asInstanceOf[AnalyzingCompiler] | |||
| val classpathOptions = ClasspathOptionsUtil.repl | |||
| compiler.console(classpathFiles, project.scalacOptions, classpathOptions, "", "", state.logger)( | |||
| val options = project.scalacOptions :+ "-Xnojline" | |||
There was a problem hiding this comment.
The flag is unlikely to change, so I don't think it's a big deal 👍
|
By the way, I just realized that we should handle cancellation for the console gracefully and filed #469. |
jvican
added a commit
that referenced
this pull request
May 3, 2018
tindzk
pushed a commit
to tindzk/bloop
that referenced
this pull request
May 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using Nailgun, the REPL is being run in a different
process than the one connected to the user's terminal, so we cannot
run Scala's ILoop with InteractiveReader - we must use SimpleReader
instead. By passing -Xnojline argument to AnalyzingCompiler.console we
make sure that it will use SimpleReader.
Fixes #385.