Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to wkw unit support #7970

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Aug 2, 2024

WK part to enable passing the user-provided unit to the wkw conversion job.

Please note that I tried to improve the typing and naming of the upload view in the frontend :). This just slipped in as an improvement.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Better test locally in conjunction with the new worker pr #3666
  • Set up a work with the version of the linked vx pr. (yarn enable-jobs)
  • Upload a dataset that needs to be converted and select a unit other than nm
  • After the upload and conversion are finished try viewing the dataset and check that the unit is according to what you configured during the upload.

Issues:


(Please delete unneeded items, merge only when none are left open)

@MichaelBuessemeyer MichaelBuessemeyer marked this pull request as ready for review August 2, 2024 09:49
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend LGTM, and works for me :) Just see my comment on parameter naming at https://github.com/scalableminds/voxelytics/pull/3666#discussion_r1703688121 which should also be applied here.

@MichaelBuessemeyer
Copy link
Contributor Author

And while reviewing please use Hide whitespace. Else far to many changes are shown

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

front-end lgtm :)

@MichaelBuessemeyer MichaelBuessemeyer enabled auto-merge (squash) August 6, 2024 11:05
@MichaelBuessemeyer MichaelBuessemeyer merged commit 7aee96d into master Aug 6, 2024
2 checks passed
@MichaelBuessemeyer MichaelBuessemeyer deleted the convert-to-wkw-unit-support branch August 6, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pass unit to convert_to_wkw worker job
3 participants