Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alignment job to take matches from skeleton into account #7967

Merged
merged 11 commits into from
Aug 8, 2024

Conversation

Tobias314
Copy link
Contributor

@Tobias314 Tobias314 commented Jul 31, 2024

Description:

  • Moves alignment job to separate tab of "AI Tools"
  • Adds option to use manual matches from a skeleton for alignment

Steps to test:

  • Create some skeleton trees for some sections of a dataset and then start an alignment job via the "AI Tools"

TODOs:

Issues:

Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @Tobias314,

I only found minor things. Well done :) The only must change form my side would be the renaming of the skeleton form item. Please see my comment for that.

Additionally I want to double check something with @fm3 :)

Edit: And maybe also the additional check for an empty skeleton tracing. I just managed to submit the job with the check mark set at the new form item, but with an empty skeleton tracing. I'd welcome a error in such a case :)

app/controllers/JobController.scala Outdated Show resolved Hide resolved
conf/webknossos.latest.routes Outdated Show resolved Hide resolved
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @Tobias314 I found another few nitpicky suggestions about variable naming. Afterwards this PR should be good to go :)
Please apply them before merging

@MichaelBuessemeyer
Copy link
Contributor

And could you please increase the width of the buttons presented in the "run a model" view? Due to one item less, there is some free and sad looking white space.

This is how it looks on the master where there is no whitespace:
image

And this is your branch with white space on the right side where another fourth button should be.
image

@Tobias314 Tobias314 enabled auto-merge (squash) August 8, 2024 13:55
@Tobias314 Tobias314 merged commit b8420b4 into master Aug 8, 2024
2 checks passed
@Tobias314 Tobias314 deleted the alignment_with_annotations branch August 8, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants