Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable AI analysis for 2D and ND datasets #7957

Merged
merged 15 commits into from
Aug 1, 2024
Merged

Disable AI analysis for 2D and ND datasets #7957

merged 15 commits into from
Aug 1, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Jul 29, 2024 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • test that "AI Analysis" button is disabled if dataset is in 2D, ND or only has color layers in uInt24 data format
  • make sure that you cannot select color layers with dataformat uint24 in layer selection (neither train nor run)
  • everything else should work as before :)

TODOs:

  • disable for 2D and ND
  • error for weird units
  • maybe disable/filter out uint24 layer for train model?
  • find out whether uint24 blacklisted or uint8 whitelisted
  • test for 2D
  • test review changes, e.g. with DS without color layer

Issues:

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Removed dev-only changes like prints and application.conf edits ❗ ❗ 💥 💥

@dieknolle3333 dieknolle3333 self-assigned this Jul 29, 2024
dieknolle3333
dieknolle3333 commented Jul 29, 2024
View reviewed changes
conf/application.conf Outdated
@@ -146,12 +146,12 @@ features {
discussionBoard = "https://forum.image.sc/tag/webknossos"
discussionBoardRequiresAdmin = false
hideNavbarLogin = false
isWkorgInstance = false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

och nöööööööö

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#neverForget

@dieknolle3333 dieknolle3333 changed the title WIP: disable AI analysis for 2D and ND datasets Disable AI analysis for 2D and ND datasets Jul 31, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review July 31, 2024 13:22
hotzenklotz
hotzenklotz approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dieknolle3333 dieknolle3333 enabled auto-merge (squash) August 1, 2024 09:13
@dieknolle3333 dieknolle3333 enabled auto-merge (squash) August 1, 2024 12:40
@dieknolle3333 dieknolle3333 merged commit ea730f7 into master Aug 1, 2024
2 checks passed
@dieknolle3333 dieknolle3333 deleted the disable-ai-models-2d-nd branch August 1, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzenklotz hotzenklotz hotzenklotz approved these changes

Assignees

@dieknolle3333 dieknolle3333

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable AI models for 2D and ND datasets
2 participants
@dieknolle3333 @hotzenklotz