Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show wrong mesh scale warning in console if not matching to any segmentation layer resolution #7921

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Jul 15, 2024

Currently, the warning that the scale of a loaded pre-computed mesh does not match the dataset scale factor is printed even in case, the mesh was calculated in a valid lower res mag. The changes of this PR now check whether the provided scale of the mesh matches any of the resolutions supported by the active segmentation layer multiplied with the dataset scale. Only in case none matches, the warning is printed to the console.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

Please test locally. I was unable to prepare a dev instance testing scenario due to not having an already uploaded dataset with a meshfile creating the mesh scale mismatch warning on the current state of the master.

I suggest testing with the l4_sample dataset. The one on the dev instances does not seem to have the mesh files triggering the warning. The mesh files likely were computed in the finest mag.

  1. Checkout the master branch.
  2. View the l4_sample dataset
  3. Load a pre-computed mesh. A warning should appear in the console regarding the scale of the loaded mesh.
  4. Switch to this branch.
  5. View the l4_sample dataset.
  6. Load a pre-computed mesh. No warning should appear in the console regarding the scale of the loaded mesh.

Issues:

…fore showing mesh scale mismatch error in console
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@MichaelBuessemeyer MichaelBuessemeyer merged commit d47fcff into master Jul 16, 2024
2 checks passed
@MichaelBuessemeyer MichaelBuessemeyer deleted the make-mesh-scale-warning-smarter branch July 16, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants