Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment name in contextmenu of dataviewport #7920

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Segment name in contextmenu of dataviewport #7920

merged 8 commits into from
Jul 11, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Jul 10, 2024 •
edited
Loading

Steps to test:

  • Open context menu of a segment in data view port.
  • If the segment has a name, you should see it at the bottom of the context menu.
  • Otherwise, nothing should change.
  • You should be able to copy the name.
  • Long and short names should be displayed nicely.

TODOs:

  • decide icon

Issues:

(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Jul 10, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review July 11, 2024 11:34
philippotto
philippotto approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@philippotto philippotto merged commit e8d5ea3 into master Jul 11, 2024
2 checks passed
@philippotto philippotto deleted the segment-name-contextmenu-dataviewport branch July 11, 2024 13:58
@philippotto
Copy link
Member

the green merge button was too tempting 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@dieknolle3333 dieknolle3333

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context menu of a segment in a data viewport should show the segment name
2 participants
@dieknolle3333 @philippotto