Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine custom names of merged agglomerates & transfer custom name to split-off segments #7877

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Jun 12, 2024

This PR improves the way custom names of segments / agglomerates are handled during proofreading. Previously, the potential custom name of the target segment was dropped in a merge action and a split-off segment always "lost" its previous custom name. Now, the custom names are merged in case of a merge and split-off segments inherit the custom name of the original agglomerate.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open a dataset with a segmentation layer with a hdf5 mapping.
  • load 2 segments & give each a custom name
  • merge these segments. The newly merged segment should have both custom names separated by a comma.
  • Merge two segments out of which only one has a custom name. The merged segment should have retained the custom name but not the default one.
  • Split of a segment from an agglomerate with a custom name. The split-off segment should have the same name as the original agglomerate.
  • Split a segment from all its neighbors. All new split off neighbors should have the custom name of the original segment in case the original segment had a custom name.

TODOs:

  • Check whether there are other proofreading actions that should be considered.

Issues:


(Please delete unneeded items, merge only when none are left open)

@MichaelBuessemeyer MichaelBuessemeyer marked this pull request as ready for review June 13, 2024 09:55
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm 👍 didn't test because I assume that you tested the mentioned proofreading operations well.

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MichaelBuessemeyer MichaelBuessemeyer removed the request for review from normanrz June 18, 2024 07:50
MichaelBuessemeyer and others added 2 commits June 18, 2024 10:20
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
@MichaelBuessemeyer MichaelBuessemeyer merged commit c36b647 into master Jun 18, 2024
2 checks passed
@MichaelBuessemeyer MichaelBuessemeyer deleted the merge-segment-names branch June 18, 2024 09:47
@MichaelBuessemeyer
Copy link
Contributor Author

just did another quick test on the dev instance to avoid a big accidental woopsie. Testing worked 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink how segment names are assigned when merging two segments
2 participants