Fix node picking regression #7732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t visible. Fix far clipping distance for flight/oblique mode.
daniel-wer
commented
Apr 3, 2024
| // The far value has to be set, since in normal rendering the far clipping is | ||
| // achieved by offsetting the plane instead of setting the far property. | ||
| camera.far = state.userConfiguration.clippingDistance; | ||
| } | ||
| camera.updateProjectionMatrix(); | ||
| return camera; |
There was a problem hiding this comment.
This is the fix for the actual regression. The camera was cloned and modified (in this function that was introduced in a recent PR), but then later in the original function, the old camera was used again.
There was a problem hiding this comment.
argh, this explains a lot of the weirdness I experienced with the clipping distances 🙈 thanks for fixing this!
normanrz
approved these changes
Apr 3, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression allowed to select nodes in orthogonal mode that were not visible.
Also, I fixed the far clipping distance for flight/oblique mode which allowed to select nodes that were not visible. In contrast to orthogonal mode, nodes that are clipping-distance-behind the plane cannot be seen in flight/oblique mode which needed to be done similarly during node picking.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)