Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix antd "info color" and markdown editing issues #7700

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Fix antd "info color" and markdown editing issues #7700

merged 5 commits into from
Mar 20, 2024

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Mar 19, 2024 •
edited
Loading

Small PR to fix

  • the ant design info color.
  • and the annotation description text input have various issues

From the antd docs:
image

Before

image

After

image

Testing

  • Change a dataset description
  • Change an annotation description.
  • In both scenarios:
    • Cursor should not jump.
    • Empty value should reset to [no description].
    • Completely empty textarea should be possible to start typing from "scratch".

Issues:

(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Mar 19, 2024
@philippotto philippotto changed the title Fix antd "info color" Fix antd "info color" and markdown editing issues Mar 19, 2024
philippotto
philippotto approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍 a changelog entry would be nice.

@hotzenklotz hotzenklotz merged commit b7041a3 into master Mar 20, 2024
1 of 2 checks passed
@hotzenklotz hotzenklotz deleted the fix-info-color branch March 20, 2024 08:26
@hotzenklotz hotzenklotz restored the fix-info-color branch March 21, 2024 08:56
@fm3 fm3 deleted the fix-info-color branch April 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@hotzenklotz hotzenklotz

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation description resets itself if deleted until empty
2 participants
@hotzenklotz @philippotto