Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tag search precise #7640

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Make tag search precise #7640

merged 3 commits into from
Feb 20, 2024

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Feb 20, 2024

The current tag search produces false positives if the tag name also appears somewhere else in the annotation properties.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • assign a t tag to an annotation in the dashboard
  • rename another annotation to contain a "t"
  • click on the t tag and check that only the one annotation is shown

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto changed the title Fix tag search Make tag search precise Feb 20, 2024
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙏 🚀.

The code looks good to me ✔️

Edit: Testing also worked 🎉

@philippotto philippotto enabled auto-merge (squash) February 20, 2024 17:28
@philippotto philippotto merged commit 877b134 into master Feb 20, 2024
2 checks passed
@philippotto philippotto deleted the fix-tag-search branch February 20, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag selection of annotations does not work with single letter tags
2 participants