Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include http api versions in buildinfo #7581

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jan 23, 2024

The buildinfo route now reports the supported HTTP API versions. Also the error message if an unsupported api version was requested is now more descriptive.

URL of deployed dev instance (used for testing):

Steps to test:

  • go to api/buildinfo should show 1 to 6 (Any suggestions on naming the fields?)
  • request api/v13/buildinfo, should show readable error message.

Issues:


@fm3 fm3 self-assigned this Jan 23, 2024
@fm3 fm3 marked this pull request as ready for review January 23, 2024 14:01
@fm3 fm3 requested a review from frcroth January 23, 2024 14:01
Copy link
Member

@frcroth frcroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the names as is

@fm3 fm3 merged commit a08d2d6 into master Jan 24, 2024
2 checks passed
@fm3 fm3 deleted the http-api-version-buildinfo branch January 24, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants