-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Time Tracking API, Revamp TimeTracking Statistics Page #7524
Conversation
…questing user is superuser
…os into time-tracking-api
@fm3 personally I think everything works as expected with your new changes, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the backend code only. Looks good. Just one comment on time zones. Not sure we have considered these before.
I did a happy path testing. Seems to work. The UI looks slick!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing went smooth :) only one small thing:
the bullet points next to the values in the per-user-time-view look weird:
maybe use a border-less table and the • symbol in front of each label. or do it like here: https://master.webknossos.xyz/statistics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
front-end looks good to me 🥇
Changes the time-tracking overview to show times spent in annotations and tasks and filter them by teams and projects. In the linked detail view, the tracked times can also be filtered by type (annotations or tasks) and project.
Backend Changes
/time/overview
to fill new user time tracking table, filtered by team, projectIds, onlyCountTasksSteps to test:
TODOs:
/time/summed/userList
api/time/groupedByInterval
?,/time/allusers
,/time/userlist
)webknossos.org/statistics
-> maybe delete whole viewCharlies todos:
for time tracking overview
include exploratives
detail view
Issues: