Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes Uri encoding in OpenGraphService #7502

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fixes Uri encoding in OpenGraphService #7502

merged 2 commits into from
Dec 13, 2023

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Dec 13, 2023 •
edited by philippotto
Loading

Don't decode the URL before constructing the URI in OpenGraphService.

Steps to test:

  • Create a sharing link
  • Add a %20 in the database in the longLink (e.g. in the orga part)
  • The sharing link should still be resolved ok (but point to a non-existing dataset)

(Please delete unneeded items, merge only when none are left open)

@normanrz normanrz requested a review from fm3 December 13, 2023 17:10
philippotto
philippotto approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 👍

@philippotto philippotto mentioned this pull request Dec 13, 2023
Closed
8 tasks
@normanrz normanrz merged commit 7fad30c into master Dec 13, 2023
2 checks passed
@normanrz normanrz deleted the fix-uri-decoding branch December 13, 2023 19:14
@fm3 fm3 mentioned this pull request Dec 13, 2023
Closed
normanrz added a commit that referenced this pull request Dec 13, 2023
@normanrz
fixes Uri encoding in OpenGraphService (#7502)
a9e7ddb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

@philippotto philippotto philippotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@normanrz @fm3 @philippotto