-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Thumbnails in Dataset Table #7479
Conversation
frontend/javascripts/dashboard/advanced_dataset/dataset_table.tsx
Outdated
Show resolved
Hide resolved
Sweet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool stuff 💯 only left smaller feedback.
frontend/javascripts/dashboard/advanced_dataset/dataset_table.tsx
Outdated
Show resolved
Hide resolved
frontend/javascripts/dashboard/advanced_dataset/dataset_table.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 👍 I'm wondering whether the thumbnails will be a noticable performance hit. The first page of the dataset table can contain up to 50 datasets. This will incur 50 additional requests (can be cached of course). One could think about deferring the loading of a thumbnail (e.g., by a simple delay or by waiting until it is scrolled into view).
However, on the dev instance it's plenty fast. Let's merge it and see how it behaves in production.
Description
" \ ,
) would get unexpectedly splitScreenshots
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
layerNames
list inAPIDatasetCompact
Follow-Up
Issues: