Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to scala 2.13 #7327

Merged
merged 26 commits into from
Oct 4, 2023
Merged

Upgrade to scala 2.13 #7327

merged 26 commits into from
Oct 4, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 9, 2023

Let’s get rid of some technical debt. Also in preparation to the upgrade to play 2.9 (their migration guide is not yet released, but it says 2.12 support is discontinued)

  • Upgrades to scala 2.13
  • Upgrades some dependencies to newer version for compatibility
  • Adapts to new syntax (added () in many places, new interface for mapping maps, no more Enumerators (had to re-write zip+nml i/o a bit), no more 'symbol literals, no more string concatenation with +, no more .zipped, new imports for java-to-scala conversions, )
  • Imports swagger-play2 into the webknossos source
  • Removes a few unused routes and classes (rather than adapt them to new scala version)

URL of deployed dev instance (used for testing):

Steps to test:

  • Browse around, annotate, download+reupload

TODOs:

  • Library Dependencies
    • for build
    • for util
    • for datastore
    • for tracingstore
    • for webknossos
  • Adapt to breaking changes
    • No more Enumerators
    • asScala api change?
    • Slick Could not initialize class com.scalableminds.webknossos.schema.Tables$
  • Adapt to scala deprecation warnings
  • Test around
  • Make CI happy
    • lint,format
    • adapt unit tests
    • snapshot tests (diff in user time tracking?)

Issues:


@fm3 fm3 added the backend label Sep 9, 2023
@fm3 fm3 self-assigned this Sep 9, 2023
@fm3 fm3 mentioned this pull request Sep 18, 2023
3 tasks
@fm3 fm3 changed the title WIP: Upgrade to scala 2.13 Upgrade to scala 2.13 Sep 25, 2023
@fm3 fm3 marked this pull request as ready for review September 25, 2023 12:39
@fm3 fm3 requested a review from normanrz October 4, 2023 09:53
@fm3 fm3 merged commit 1fd1389 into master Oct 4, 2023
2 checks passed
@fm3 fm3 deleted the scala213 branch October 4, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Scala 2.13
2 participants