Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proofreading docs to reflect current state #7212

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Jul 18, 2023

Also, I enabled Shift + middle-click to load agglomerate skeletons in all tools, not just the skeleton tool as that is how it is documented and shown in the context menu.

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Follow the instructions in the docs to check that they reflect the current state of the proofreading tool
  • Open an annotation on a dataset with an agglomerate mapping.
  • Activate an agglomerate mapping.
  • Use Shift + middle-click in any tool to load agglomerate skeletons

(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Jul 18, 2023
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍 the docs now don't mention that you can also do split/merge operations on the agglomerate skeleton. however, this might be fine, because we don't really want to encourage this in the long term? just wanted to note this..

@daniel-wer
Copy link
Member Author

great 👍 the docs now don't mention that you can also do split/merge operations on the agglomerate skeleton. however, this might be fine, because we don't really want to encourage this in the long term? just wanted to note this..

There's this sentence just below the section that I changed:

In addition to the handy shortcuts available from the right-click context menu, users can also directly modify the super-voxel graph like any other skeleton to manually add/remove nodes and edges for fine-grained control.

I'd say that's fine :)

@daniel-wer daniel-wer merged commit 1211e05 into master Jul 18, 2023
1 check passed
@daniel-wer daniel-wer deleted the proofreading-docs branch July 18, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants