Add pagination #3505
Merged
Add pagination #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philippotto can you give me some feedback? |
rschwanhold
commented
Nov 29, 2018
rschwanhold
commented
Nov 29, 2018
philippotto
reviewed
Nov 29, 2018
fm3
requested changes
Dec 13, 2018
There was a problem hiding this comment.
cool! backend LGTM. please fill in the PR template and update the changelog. if any of these routes are mentined in the rest api docs, please update those as well. since only new optional parameters have been added, no new api version number is required, but those params should be mentioned :)
philippotto
reviewed
Dec 20, 2018
app/assets/javascripts/dashboard/explorative_annotations_view.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/dashboard/explorative_annotations_view.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/dashboard/explorative_annotations_view.js
Outdated
Show resolved
Hide resolved
fm3
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
load more tasks/load more annotationsIssues:
- [ ] Updated migration guide if applicable- [ ] Needs datastore update after deployment'