Fix compile/skip and libraryDependencies for scala native #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changes LGTM, but now MiMa is failing in the Native builds there is a discussion about whether MiMa even makes sense to enable except on the JVM at scala/scala-xml#517 -- TL;DR is that it might make some limited amount of sense to enable, but I wouldn't be opposed to simply disabling it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying this PR will fix the
compile / skip- andlibraryDependencies-settings for scala native. Seems I got some if-statements wrong in #347. After this is merged we should have non-empty jars again for scala native, see #380.