Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Avoid requiring -i to propagate output #3

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Oct 18, 2022

This removes the following drawback:

  • when compiling things in non-interactive mode, the output of Scala CLI, that prints errors and warnings, is sometimes trapped - use of ./mill -i is recommended, which slows Mill commands a bit

@lolgab lolgab marked this pull request as draft October 18, 2022 12:16
@lolgab lolgab marked this pull request as ready for review October 18, 2022 13:46
@lolgab lolgab changed the title Avoid requiring -i to propagate output Fix: Avoid requiring -i to propagate output Oct 18, 2022
Copy link
Collaborator

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lolgab, that's neat!

@alexarchambault alexarchambault merged commit ef2ca68 into scala-cli:main Oct 18, 2022
@alexarchambault
Copy link
Collaborator

alexarchambault commented Oct 18, 2022

By the way, I'm phasing out mill-scala-cli from the projects I used from (Scala CLI, coursier, maybe Almond too), as it seems recent changes in Mill fixed the incremental issues I was seeing. So I'm not sure who uses mill-scala-cli any more… Or what the project future will be…

@lolgab lolgab deleted the avoid-i-to-propagate-output branch October 18, 2022 17:11
@lolgab
Copy link
Contributor Author

lolgab commented Oct 18, 2022

I was reading the incremental compilation issue description in Mill and was amused looking at how easy to switch the compile task to use a completely different toolchain. If the problem is fixed upstream is even better. This project can become a showcase of Mill's customization options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants