Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fork to most recent changes #155

Merged
merged 11 commits into from
Sep 29, 2023
Merged

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Sep 27, 2023

The changes come strictly from already merged changes to mainline bloop

Previously, we would show an error whenever a native project was loaded, since we can't currently run tests for native. However, this will pop up currently in Metals as a server error, while it's more of a warning. There is nothing the user can do about it. Now, we report this as a warning.
Previously, tracing was enabled by default and user could get stack traces logged by the zipkin trace. Now, we require setting `bloop.tracing.enabled` property.

Tracing is not used heavily currently, so this should not be an issue.

Fixes scalacenter#2108
@tgodzik tgodzik force-pushed the updateForking branch 2 times, most recently from 0dfd9af to 272c558 Compare September 29, 2023 09:16
Copy link
Collaborator

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit 7b633eb into scala-cli:main Sep 29, 2023
12 of 13 checks passed
@tgodzik tgodzik deleted the updateForking branch September 29, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants