Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watch on useScaffoldEventHistory #38

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Add watch on useScaffoldEventHistory #38

merged 4 commits into from
Nov 20, 2023

Conversation

carletex
Copy link
Member

We just merged: https://github.com/scaffold-eth/scaffold-eth-2/pull/597/files

So we need to update the docs to reflect the changes.


Used the same comment present in the code. Add it as the first non-mandatory param in the list and also reordered blockData (I think it makes sense to be next to the other data ones)

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scaffold-eth-2-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 0:59am

Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it great, added a small nitpick comment, can be totally ignored 😅🙌

@technophile-04
Copy link
Collaborator

Tysm all !! Merging this 🙌

@technophile-04 technophile-04 merged commit 6ee23b4 into main Nov 20, 2023
3 checks passed
@technophile-04 technophile-04 deleted the event-history branch November 20, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants