Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundry keystore makefile #912

Merged
merged 5 commits into from
Aug 26, 2024
Merged

foundry keystore makefile #912

merged 5 commits into from
Aug 26, 2024

Conversation

technophile-04
Copy link
Collaborator

@technophile-04 technophile-04 commented Aug 20, 2024

Description:

Switched to makefile. Also tweaked a flow a bit in latest changes of #878 while deploying to live network you had to pass the raw password in cli:

yarn deploy --network sepolia --password my_password

# had to do same for yarn account 

Now we are using makefiles and in the new flow :

yarn deploy

^ By default deploying to locahost won't ask you for password (already tackled in latest #878)

But when you pass it an live network which is not locahost then it will give you an interactive cli to type password.

Same for yarn account

cc @jrcarlos2000 to check once if I did not miss anything.

@technophile-04 technophile-04 changed the base branch from main to foundry August 20, 2024 09:36
@technophile-04 technophile-04 changed the base branch from foundry to feat/keystore August 20, 2024 09:36
@technophile-04
Copy link
Collaborator Author

Tysm @jrcarlos2000! updated with all the changes! Merging this 🙌

@technophile-04 technophile-04 merged commit 23b283e into feat/keystore Aug 26, 2024
@technophile-04 technophile-04 deleted the keystore-makefile branch August 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants